[libvirt] [PATCH] qemu: better error message when block job can't succeed

[Eric Blake]

On 10/28/2014 10:28 PM, Michal Privoznik wrote:
> On 28.10.2014 15:31, Eric Blake wrote:
>> https://bugzilla.redhat.com/show_bug.cgi?id=1140981 reports that
>> the qemu-kvm shipped as part of RHEL 7.0 intentionally cripples
>> block jobs by removing the 'block-stream' QMP command, but that
>> our probe for whether block jobs work was merely whether
>> 'block-job-cancel' exists.  Meanwhile, older qemu spelled the
>> two commands block_stream and block_job_cancel.  We know of no
>> qemu build that has block-stream while lacking block-job-cancel,
>> so it is easiest to change our witness to the command that
>> starts a job rather than ends one.  On RHEL, this results in
>> changing the message from an ugly:
>>
>>   error: Requested operation is not valid: Command 'block-stream' is
>> not found
>>
>> to a nicer:
>>
>>   error: unsupported configuration: block jobs not supported with this
>> qemu binary
>>

> 
> ACK and safe for the freeze.

Pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141029/8ec8b9b6/attachment-0001.sig>