[libvirt] [PATCH 2/2] lxc: improve error message for invalid blkiotune settings

Chen, Hanxiao chenhanxiao at cn.fujitsu.com
Thu Oct 30 02:16:11 UTC 2014



> -----Original Message-----
> From: libvir-list-bounces at redhat.com [mailto:libvir-list-bounces at redhat.com]
> On Behalf Of Martin Kletzander
> Sent: Wednesday, October 29, 2014 11:45 PM
> To: libvir-list at redhat.com
> Subject: [libvirt] [PATCH 2/2] lxc: improve error message for invalid blkiotune
> settings
> 
> Before:
>   $ virsh blkiotune dummy --device-read-bytes-sec /dev/sda,-1
>   error: Unable to change blkio parameters
>   error: invalid argument: unable to parse blkio device
>   'device_read_bytes_sec' '/dev/sda,-1'
> 
> After:
>   $ virsh blkiotune dummy --device-read-bytes-sec /dev/sda,-1
>   error: Unable to change blkio parameters
>   error: invalid argument: invalid value '-1' for parameter
>   'device_read_bytes_sec' of device '/dev/sda'
> 
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1131306
> 
> Signed-off-by: Martin Kletzander <mkletzan at redhat.com>

That would be much easier for users.

Reviewed-by: Chen Hanxiao <chenhanxiao at cn.fujitsu.com>

Thanks,
- Chen




More information about the libvir-list mailing list