[libvirt] [PATCH] Reject live update of offloading options

Eric Blake eblake at redhat.com
Thu Oct 30 14:50:48 UTC 2014


On 10/30/2014 06:38 AM, Ján Tomko wrote:
> https://bugzilla.redhat.com/show_bug.cgi?id=1155441
> ---
>  src/qemu/qemu_hotplug.c | 13 ++++++++++++-
>  1 file changed, 12 insertions(+), 1 deletion(-)

ACK. Safe during the freeze.

> 
> diff --git a/src/qemu/qemu_hotplug.c b/src/qemu/qemu_hotplug.c
> index 33241fb..d3bf392 100644
> --- a/src/qemu/qemu_hotplug.c
> +++ b/src/qemu/qemu_hotplug.c
> @@ -1981,7 +1981,18 @@ qemuDomainChangeNet(virQEMUDriverPtr driver,
>           olddev->driver.virtio.txmode != newdev->driver.virtio.txmode ||
>           olddev->driver.virtio.ioeventfd != newdev->driver.virtio.ioeventfd ||
>           olddev->driver.virtio.event_idx != newdev->driver.virtio.event_idx ||
> -         olddev->driver.virtio.queues != newdev->driver.virtio.queues)) {
> +         olddev->driver.virtio.queues != newdev->driver.virtio.queues ||
> +         olddev->driver.virtio.host.csum != newdev->driver.virtio.host.csum ||
> +         olddev->driver.virtio.host.gso != newdev->driver.virtio.host.gso ||
> +         olddev->driver.virtio.host.tso4 != newdev->driver.virtio.host.tso4 ||
> +         olddev->driver.virtio.host.tso6 != newdev->driver.virtio.host.tso6 ||
> +         olddev->driver.virtio.host.ecn != newdev->driver.virtio.host.ecn ||
> +         olddev->driver.virtio.host.ufo != newdev->driver.virtio.host.ufo ||
> +         olddev->driver.virtio.guest.csum != newdev->driver.virtio.guest.csum ||
> +         olddev->driver.virtio.guest.tso4 != newdev->driver.virtio.guest.tso4 ||
> +         olddev->driver.virtio.guest.tso6 != newdev->driver.virtio.guest.tso6 ||
> +         olddev->driver.virtio.guest.ecn != newdev->driver.virtio.guest.ecn ||
> +         olddev->driver.virtio.guest.ufo != newdev->driver.virtio.guest.ufo)) {
>          virReportError(VIR_ERR_OPERATION_UNSUPPORTED, "%s",
>                         _("cannot modify virtio network device driver attributes"));
>          goto cleanup;
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20141030/2d91dc5f/attachment-0001.sig>


More information about the libvir-list mailing list