[libvirt] [PATCH 1/2] qemu: migration:Release nbd port from migrationPorts instead of remotePorts

[John Ferlan]

On 10/31/2014 06:02 AM, Ján Tomko wrote:
> On 10/31/2014 09:16 AM, weiwei li wrote:
>> commit 3e1e16aa8d4238241a1806cb9bdb3b9ad60db777(Use a port from the
>> migration range for NBD as well) change ndb port allocation from
>> remotePorts to migrationPorts, but does not change the port releasing
>> process, which makes an error when migration seveal times(above 64).
> 
> Oops, thanks for catching that.
> 

While you're at it....
 * s/commit/commit id/
 * Add a space between 777 and ( in the first sentance
   * Note: could also change to "commit id '3e1e16aa' (...)"
 * s/when migration seveal times/when migrating several times/

John
>>
>> Signed-off-by: Weiwei Li <nuonuoli at tencent.com <mailto:nuonuoli at tencent.com>>
>> ---
> 
> Your mail was sent as HTML. After applying it with 'git am', there were some
> unrelated strings in the commit message:
>     --20cf306848c9caea5c0506b39c3d
>     Content-Type: text/plain; charset=UTF-8
> 
> Please use 'git send-email' in the future.
> 
>>  src/qemu/qemu_migration.c |    8 ++++----
>>  src/qemu/qemu_process.c   |    2 +-
>>  2 files changed, 5 insertions(+), 5 deletions(-)
>>
>> diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
>> index ca70e35..0ad8054 100644
>> --- a/src/qemu/qemu_migration.c
>> +++ b/src/qemu/qemu_migration.c
>> @@ -1351,7 +1351,7 @@ qemuMigrationStartNBDServer(virQEMUDriverPtr driver,
>>      unsigned short port = 0;
>>      char *diskAlias = NULL;
>>      size_t i;
>> -
>> +    VIR_DEBUG("DEBUG: in qemuMigrationStartNBDServer");
>>      for (i = 0; i < vm->def->ndisks; i++) {
>>          virDomainDiskDefPtr disk = vm->def->disks[i];
>>  
> 
> ACK, I will remove the leftover debug message and push the patch later today.
> 
> Jan
> 
> 
> 
> --
> libvir-list mailing list
> libvir-list at redhat.com
> https://www.redhat.com/mailman/listinfo/libvir-list
>