[libvirt] [PATCH 1/5] qemu: Rename DEFAULT_JOB_MASK to QEMU_DEFAULT_JOB_MASK

Peter Krempa pkrempa at redhat.com
Wed Sep 3 13:53:02 UTC 2014


Be consistend with naming of private defines. Also line up code
correctly in few places where the macro is used.
---
 src/qemu/qemu_domain.c    | 2 +-
 src/qemu/qemu_domain.h    | 2 +-
 src/qemu/qemu_driver.c    | 8 ++++----
 src/qemu/qemu_migration.c | 6 +++---
 4 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/src/qemu/qemu_domain.c b/src/qemu/qemu_domain.c
index e9506e0..543c064 100644
--- a/src/qemu/qemu_domain.c
+++ b/src/qemu/qemu_domain.c
@@ -162,7 +162,7 @@ qemuDomainObjResetAsyncJob(qemuDomainObjPrivatePtr priv)
     job->asyncJob = QEMU_ASYNC_JOB_NONE;
     job->asyncOwner = 0;
     job->phase = 0;
-    job->mask = DEFAULT_JOB_MASK;
+    job->mask = QEMU_DEFAULT_JOB_MASK;
     job->start = 0;
     job->dump_memory_only = false;
     job->asyncAbort = false;
diff --git a/src/qemu/qemu_domain.h b/src/qemu/qemu_domain.h
index 8736889..f959664 100644
--- a/src/qemu/qemu_domain.h
+++ b/src/qemu/qemu_domain.h
@@ -54,7 +54,7 @@
 # endif

 # define JOB_MASK(job)                  (1 << (job - 1))
-# define DEFAULT_JOB_MASK               \
+# define QEMU_DEFAULT_JOB_MASK          \
     (JOB_MASK(QEMU_JOB_QUERY) |         \
      JOB_MASK(QEMU_JOB_DESTROY) |       \
      JOB_MASK(QEMU_JOB_ABORT))
diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 239a300..dd831b0 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -13207,9 +13207,9 @@ qemuDomainSnapshotCreateActiveExternal(virConnectPtr conn,
             goto endjob;

         /* allow the migration job to be cancelled or the domain to be paused */
-        qemuDomainObjSetAsyncJobMask(vm, DEFAULT_JOB_MASK |
-                                     JOB_MASK(QEMU_JOB_SUSPEND) |
-                                     JOB_MASK(QEMU_JOB_MIGRATION_OP));
+        qemuDomainObjSetAsyncJobMask(vm, QEMU_DEFAULT_JOB_MASK |
+                                         JOB_MASK(QEMU_JOB_SUSPEND) |
+                                         JOB_MASK(QEMU_JOB_MIGRATION_OP));

         cfg = virQEMUDriverGetConfig(driver);
         if (cfg->snapshotImageFormat) {
@@ -13241,7 +13241,7 @@ qemuDomainSnapshotCreateActiveExternal(virConnectPtr conn,
         memory_unlink = true;

         /* forbid any further manipulation */
-        qemuDomainObjSetAsyncJobMask(vm, DEFAULT_JOB_MASK);
+        qemuDomainObjSetAsyncJobMask(vm, QEMU_DEFAULT_JOB_MASK);
     }

     /* now the domain is now paused if:
diff --git a/src/qemu/qemu_migration.c b/src/qemu/qemu_migration.c
index 9cfb77e..0954751 100644
--- a/src/qemu/qemu_migration.c
+++ b/src/qemu/qemu_migration.c
@@ -4907,9 +4907,9 @@ qemuMigrationJobStart(virQEMUDriverPtr driver,
     if (job == QEMU_ASYNC_JOB_MIGRATION_IN) {
         qemuDomainObjSetAsyncJobMask(vm, QEMU_JOB_NONE);
     } else {
-        qemuDomainObjSetAsyncJobMask(vm, DEFAULT_JOB_MASK |
-                                     JOB_MASK(QEMU_JOB_SUSPEND) |
-                                     JOB_MASK(QEMU_JOB_MIGRATION_OP));
+        qemuDomainObjSetAsyncJobMask(vm, QEMU_DEFAULT_JOB_MASK |
+                                         JOB_MASK(QEMU_JOB_SUSPEND) |
+                                         JOB_MASK(QEMU_JOB_MIGRATION_OP));
     }

     priv->job.info.type = VIR_DOMAIN_JOB_UNBOUNDED;
-- 
2.0.2




More information about the libvir-list mailing list