[libvirt] [PATCH 0/5] Fix problems caused by FD passing to session daemon
Richard W.M. Jones
rjones at redhat.com
Tue Sep 9 11:23:53 UTC 2014
On Mon, Sep 08, 2014 at 07:46:34AM +0200, Martin Kletzander wrote:
> There were various problems introduced by the series on FD passing.
> The path for the socket was not created, the socket was not removed
> before binding it, etc. Let's see if it's any better this time.
>
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=927369
> Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1138604
>
> Martin Kletzander (5):
> rpc: reformat the flow to make a bit more sense
> remove redundant pidfile path constructions
> util: fix potential leak in error codepath
> util: get rid of unnecessary umask() call
> rpc: make daemon spawning a bit more intelligent
>
> daemon/libvirtd.c | 41 ++------------
> src/libvirt_private.syms | 1 +
> src/locking/lock_daemon.c | 42 ++-------------
> src/rpc/virnetsocket.c | 133 +++++++++++++++++++++++++++++++---------------
> src/util/virpidfile.c | 48 ++++++++++++++++-
> src/util/virpidfile.h | 7 ++-
> 6 files changed, 151 insertions(+), 121 deletions(-)
I tested the patch series and it appears to fix the problem in
bug 1138604. I used the test procedure described here:
https://bugzilla.redhat.com/show_bug.cgi?id=1138604#c2
Tested-by: Richard W.M. Jones <rjones at redhat.com>
Rich.
--
Richard Jones, Virtualization Group, Red Hat http://people.redhat.com/~rjones
Read my programming and virtualization blog: http://rwmj.wordpress.com
libguestfs lets you edit virtual machines. Supports shell scripting,
bindings from many languages. http://libguestfs.org
More information about the libvir-list
mailing list