[libvirt] [PATCH 19/26] network_conf: Resolve Coverity FORWARD_NULL
Peter Krempa
pkrempa at redhat.com
Thu Sep 11 09:27:31 UTC 2014
On 09/05/14 00:26, John Ferlan wrote:
> The code compares def->forwarders when deciding to return 0 at a
> couple of points, then uses "def->nfwds" as a way to index into
> the def->forwarders array. That reference results in Coverity
> complaining that def->forwarders being NULL was checked as part
> of an arithmetic OR operation where failure could be any one 5
> conditions, but that is not checked when entering the loop to
> dereference the array. Changing the comparisons to use nfwds
> will clear the warnings
>
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
> src/conf/network_conf.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140911/57db7698/attachment-0001.sig>
More information about the libvir-list
mailing list