[libvirt] [PATCH 12/26] virsh: Resolve Coverity DEADCODE
Peter Krempa
pkrempa at redhat.com
Thu Sep 11 09:57:53 UTC 2014
On 09/05/14 00:26, John Ferlan wrote:
> Coverity points out that if 'dom' isn't returned from virDomainQemuAttach,
> then the code already jumps to cleanup, so there was no need for the
> subsequent if (dom != NULL) check.
>
> I moved the error message about failure into the goto cleanup on failure
> and then removed the if (dom != NULL)
>
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
> tools/virsh-domain.c | 16 +++++++---------
> 1 file changed, 7 insertions(+), 9 deletions(-)
>
ACK
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140911/fc306352/attachment-0001.sig>
More information about the libvir-list
mailing list