[libvirt] [PATCH 2/3] qemu_cgroup: Adjust spacing around incrementor
John Ferlan
jferlan at redhat.com
Tue Sep 16 00:34:42 UTC 2014
On 09/15/2014 08:13 PM, John Ferlan wrote:
> Change "i+1" to "i + 1"
>
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
> src/qemu/qemu_cgroup.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
> diff --git a/src/qemu/qemu_cgroup.c b/src/qemu/qemu_cgroup.c
> index c1d89bb..9d39370 100644
> --- a/src/qemu/qemu_cgroup.c
> +++ b/src/qemu/qemu_cgroup.c
> @@ -1140,7 +1140,8 @@ qemuSetupCgroupForIOThreads(virDomainObjPtr vm)
> /* IOThreads are numbered 1..n, although the array is 0..n-1,
> * so we will account for that here
> */
> - if (virCgroupNewIOThread(priv->cgroup, i+1, true, &cgroup_iothread) < 0)
> + if (virCgroupNewIOThread(priv->cgroup, i + 1, true,
> + &cgroup_iothread) < 0)
> goto cleanup;
>
> /* move the thread for iothread to sub dir */
> @@ -1159,13 +1160,13 @@ qemuSetupCgroupForIOThreads(virDomainObjPtr vm)
> * qemuSetupCgroupIOThreadsPin will fail. */
> for (j = 0; j < def->cputune.niothreadspin; j++) {
> /* IOThreads are numbered/named 1..n */
> - if (def->cputune.iothreadspin[j]->vcpuid != i+1)
> + if (def->cputune.iothreadspin[j]->vcpuid != i + 1)
> continue;
>
> if (qemuSetupCgroupIOThreadsPin(cgroup_iothread,
> def->cputune.iothreadspin,
> def->cputune.niothreadspin,
> - i+1) < 0)
> + i + 1) < 0)
> goto cleanup;
>
> break;
>
And another one to squash in - hurrying too much for the late hour:
diff --git a/src/qemu/qemu_process.c b/src/qemu/qemu_process.c
index a2efdca..daca7c1 100644
--- a/src/qemu/qemu_process.c
+++ b/src/qemu/qemu_process.c
@@ -2358,7 +2358,7 @@ qemuProcessSetIOThreadsAffinity(virDomainObjPtr vm)
/* set affinity only for existing vcpus */
if (!(pininfo = virDomainVcpuPinFindByVcpu(def->cputune.iothreadspin,
def->cputune.niothreadspin,
- i+1)))
+ i + 1)))
continue;
if (virProcessSetAffinity(priv->iothreadpids[i], pininfo->cpumask) < 0)
More information about the libvir-list
mailing list