[libvirt] [PATCH v2 1/3] docs, conf, schema: add support for shmem device

[Michal Privoznik]

On 25.09.2014 16:35, Martin Kletzander wrote:
> On Thu, Sep 25, 2014 at 04:21:14PM +0200, Levente Kurusa wrote:
>> Hi,
>>
>> On Thu, Sep 25, 2014 at 03:37:46PM +0200, Michal Privoznik wrote:
>>> On 25.09.2014 11:45, Martin Kletzander wrote:
>>> [...]
>>>
>>> Where do these restrictions come from? If they're result of qemu
>>> implementation, than they should be checked in 3/3. If other HV learned
>>> shmem these limitations may not apply to it. Or is it a kernel thing
>>> that
>>> only areas with 1MB granularity can be mapped? Moreover, if such
>>> granularity
>>> is required, does it makes sense to store the size in bytes?
>>>
>
> I wanted to make it more future-proof.  That is that this way we can
> start storing the size in MB any time we want and we can lax the
> parsing whenever wanted.
>
> If you want, I can just store the value in MiB for now or remove the
> check (but not both, of course).  I'd be in favour of the first thing.

Yeah, so just drop the check here and leave it in src/qemu/. And store 
the value in bytes. That's okay - I was just curios.

Michal