[libvirt] [PATCH] New features implemented in hyperv libvirt driver

[Yves Vinter]

Hi Eric,



As you know, the is no more development in hyperv libvirt driver since version 0.10.2.

The last development  was committed  2 years ago:


2012-09-06

Peter Krempa<http://libvirt.org/git/?p=libvirt.git;a=search;s=Peter+Krempa;st=author>

hyperv: Add implementation for virConnectListAllDomains()<http://libvirt.org/git/?p=libvirt.git;a=commit;h=60d0ecdaa140b34241e0be15a6e1c9a0581acf19>

tree<http://libvirt.org/git/?p=libvirt.git;a=tree;f=src/hyperv;hb=60d0ecdaa140b34241e0be15a6e1c9a0581acf19> | commitdiff<http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=60d0ecdaa140b34241e0be15a6e1c9a0581acf19>




Subsequent commits are fixes for reported issues; the last commit has been done about 2 month ago:


2014-07-03

Ján Tomko<http://libvirt.org/git/?p=libvirt.git;a=search;s=J%C3%A1n+Tomko;st=author>

Use virBufferCheckError everywhere we report OOM error<http://libvirt.org/git/?p=libvirt.git;a=commit;h=92a8e72f9de5b4c435f66fd68cfde623225f13ba>

tree<http://libvirt.org/git/?p=libvirt.git;a=tree;f=src/hyperv;hb=92a8e72f9de5b4c435f66fd68cfde623225f13ba> | commitdiff<http://libvirt.org/git/?p=libvirt.git;a=commitdiff;h=92a8e72f9de5b4c435f66fd68cfde623225f13ba>




Therefore, I didn’t miss any features … (verified after a sync)



I understand that it would be easier for you to review the code to have the patch split by feature.

I will make may best to help you in this way…



Is that the last requirement ?



Thanks,

Yves.



-----Message d'origine-----
De : Eric Blake [mailto:eblake at redhat.com]
Envoyé : jeudi 25 septembre 2014 18:59
À : Yves Vinter; libvir-list at redhat.com
Objet : Re: [libvirt] [PATCH] New features implemented in hyperv libvirt driver



On 09/25/2014 06:38 AM, Yves Vinter wrote:

> Authors: Simon Rastello (Bull), Adrien Kantcheff (Bull), Yves Vinter

> (Bull)

>

> *** Summary of new features added in hyperv driver version 1.2.9 ***

>

> - Added a mutex to prevent concurrent requests from being run

> simultaneously [WSMAN libray not thread-safe]

> - Support of default authentication (credentials specified in

> ~/.config/libvirt/auth.conf)

> - Support of new types of WSMAN requests involving passing complex parameters (simple types, EPR, embedded objects)

>   Required a new auto-generated header file to get the type of objects

> attributes (hyperv_wmi_classes_attr.generated.h)

> - New functions:

>             - host management (in hyperv_driver module)

>                           - capabilities (limited)

>             - domain management (in hyperv_driver module)

>                           - domain creation from an XML description

>                           - domain destruction

>                           - attachment of pre-existing disk images on IDE controller

>                           - attachment of Synthetic network devices

>                           - memory and vcpu management (get and set methods)

>                           - autostart, shutdown, ...

>             - network management (in hyperv_network_driver module)

>                           - list available networks

>                           - informations for a specified network

>   Required the declaration of new classes (in

> hyperv_wmi_generator.input)

> - Fixed several memory leak issues



Please split each of these bulleted list items into a separate patch, for easier review.  No one likes to review a 150k single patch.



Also, it looks like you just missed feature freeze for 1.2.9; by the time you've split the series, it is probably a better candidate for inclusion in 1.2.10 around the end of October.



--

Eric Blake   eblake redhat com    +1-919-301-3266

Libvirt virtualization library http://libvirt.org


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140926/08f18c9f/attachment-0001.htm>