[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [python PATCH v2 2/5] API: Skip 'virDomainStatsRecordListFree'



On 09/01/14 22:18, Pavel Hrdina wrote:
> From: Peter Krempa <pkrempa redhat com>
> 
> The new API function doesn't make sense to be exported in python. The
> bindings will return native types instead of the struct array.
> 
> Signed-off-by: Peter Krempa <pkrempa redhat com>
> Signed-off-by: Pavel Hrdina <phrdina redhat com>
> ---
>  generator.py  | 1 +
>  sanitytest.py | 3 +++
>  2 files changed, 4 insertions(+)
> 

> diff --git a/sanitytest.py b/sanitytest.py
> index 4f4a648..10cf9f0 100644
> --- a/sanitytest.py
> +++ b/sanitytest.py
> @@ -81,6 +81,9 @@ for cname in wantfunctions:
>      if name[0:23] == "virNetworkDHCPLeaseFree":
>          continue
>  
> +    if name[0:28] == "virDomainStatsRecordListFree":
> +        continue
> +

Thanks for catching this. I didn't run the sanity test :/

>      # These aren't functions, they're callback signatures
>      if name in ["virConnectAuthCallbackPtr", "virConnectCloseFunc",
>                  "virStreamSinkFunc", "virStreamSourceFunc", "virStreamEventCallback",
> 

ACK,

Peter


Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]