[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [python PATCH] override: Fix two uninitialized variables in convertDomainStatsRecord



py_record_domain and py_record_stats would be accessed uninitialized if
an out-of-memory condition would happen in the first loop. Unlikely, but
coverity complained.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1136354
---

Pushed as trivial.

 libvirt-override.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/libvirt-override.c b/libvirt-override.c
index 17ea042..872e33b 100644
--- a/libvirt-override.c
+++ b/libvirt-override.c
@@ -7963,8 +7963,8 @@ convertDomainStatsRecord(virDomainStatsRecordPtr *records,
 {
     PyObject *py_retval;
     PyObject *py_record;
-    PyObject *py_record_domain;
-    PyObject *py_record_stats;
+    PyObject *py_record_domain = NULL;
+    PyObject *py_record_stats = NULL;
     size_t i;

     if (!(py_retval = PyList_New(nrecords)))
-- 
2.0.2


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]