[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 00/11] bulk stats: QEMU implementation



----- Original Message -----
> From: "Eric Blake" <eblake redhat com>
> To: "Francesco Romani" <fromani redhat com>, libvir-list redhat com
> Sent: Wednesday, September 3, 2014 1:15:38 AM
> Subject: Re: [libvirt] [PATCHv2 00/11] bulk stats: QEMU implementation
> 
> On 09/02/2014 06:31 AM, Francesco Romani wrote:
> > This patchset enhances the QEMU support
> > for the new bulk stats API to include
> > equivalents of these APIs:
> > 
> > virDomainBlockInfo
> > virDomainGetInfo - for balloon stats
> > virDomainGetCPUStats
> > virDomainBlockStatsFlags
> > virDomainInterfaceStats
> > virDomainGetVcpusFlags
> > virDomainGetVcpus
> > 
> > This subset of API is the one oVirt relies on.
> > Scale/stress test on an oVirt test environment is in progress.
> > 
> > changes in v2: polishing and optimizations.
> > - incorporated feedback from Li Wei (thanks)
> > - added documentation
> > - optimized block group to gather all the information with just
> >   one call to QEMU monitor
> > - stripped to bare bones merged the 'block info' group into the
> >   'block' group - oVirt actually needs just one stat from there
> > - reorganized the keys to be more consistent and shorter.
> 
> Missing is virsh exposure of the new stat groups (Li's series gave an
> example for adding --block).

Sure, will add with a followup patch.
One question, though.
Do we want default to expose nothing, and options to add groups, is this
correct?

So usage would be something like

virsh domstats  # equivalent to --all , I suppose
virsh domstats --block  # only block group
virsh domstats --interface --vcpu  # only vcpu and interface

Thanks and bests,


-- 
Francesco Romani
RedHat Engineering Virtualization R & D
Phone: 8261328
IRC: fromani


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]