[libvirt] [PATCHv2 00/11] bulk stats: QEMU implementation

[Eric Blake]

On 09/03/2014 01:04 AM, Francesco Romani wrote:
>>
>> Missing is virsh exposure of the new stat groups (Li's series gave an
>> example for adding --block).
> 
> Sure, will add with a followup patch.
> One question, though.
> Do we want default to expose nothing, and options to add groups, is this
> correct?

Correct - the API is already wired that way (stats == 0 implies list all
stats; non-zero stats says list just the requested stats).

> 
> So usage would be something like
> 
> virsh domstats  # equivalent to --all , I suppose

Yes, except I don't think we need an actual --all flag.

> virsh domstats --block  # only block group
> virsh domstats --interface --vcpu  # only vcpu and interface

Yep, looks right to me :)

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140903/bf40d498/attachment-0001.sig>