[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/6] Coverity patches to resolve RESOURCE_LEAK




On 09/01/2014 08:08 AM, Wang Rui wrote:
> Another six pathes to fix resource leak.
> But this may not be the end.
> 
> Wang Rui (6):
>   tests: Resolve Coverity RESOURCE_LEAK in commandhelper
>   test_conf: Resolve Coverity RESOURCE_LEAK
>   remote: Resolve Coverity RESOURCE_LEAK
>   qemu_process: Resolve Coverity RESOURCE_LEAK
>   vircgroup: Resolve Coverity RESOURCE_LEAK
>   lxc_container: Resolve Coverity RESOURCE_LEAK
> 
>  daemon/remote.c         |  4 +++-
>  src/lxc/lxc_container.c |  4 ++++
>  src/qemu/qemu_process.c |  1 +
>  src/util/vircgroup.c    |  2 +-
>  tests/commandhelper.c   | 15 +++++++++------
>  tests/test_conf.c       |  4 ++--
>  6 files changed, 20 insertions(+), 10 deletions(-)
> 

ACK series - made a couple of adjustments prior to push..

Patch1 didn't apply cleanly after '0c07d360f' - refactored a bit to
change "error" to "cleanup" and then use 'ret = EXIT_FAILURE' at
initialization time and 'ret = EXIT_SUCCESS' when everything succeeds,
allowing just a return ret

Patch6 needed a few extra spaces in the last VIR_FREE


John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]