[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 07/18] blockjob: split up virsh blockjob info



On 08/31/14 06:02, Eric Blake wrote:
> I have plans to make future enhancements to the job list mode,
> which will be easier to do if the common blockJobImpl function
> is not mixing a query command with multiple modify commands.
> Besides, it just feels weird that all callers to blockJobImpl
> had to supply both a bandwidth input argument (unused for info
> mode) and an info output argument (unused for all other modes);
> not to mention I just made similar cleanups on the libvirtd
> side.
> 
> The only reason blockJobImpl returned int was because of info
> mode returning -1/0/1 (all other job API are -1/0), so that
> can also be cleaned up.
> 
> * tools/virsh-domain.c (blockJobImpl): Change signature and return
> value.  Drop info handling.
> (cmdBlockJob): Handle info here.
> (cmdBlockCommit, cmdBlockCopy, cmdBlockPull): Adjust callers.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---
>  tools/virsh-domain.c | 97 +++++++++++++++++++++++++++++++---------------------
>  1 file changed, 58 insertions(+), 39 deletions(-)
> 


ACK,

Peter


Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]