[libvirt] [PATCH 03/26] storage: Resolve Coverity UNUSED_VALUE

John Ferlan jferlan at redhat.com
Thu Sep 4 22:26:11 UTC 2014


Since cd4d547576a4f0371d1d4d4e0ca6db124c5ba257

Coverity notes that setting 'ret = -3' prior to the unconditional
setting of 'ret = 0' will cause the value to be UNUSED.

Since the comment indicates that it is expect to allow the code
to continue, just remove the ret = -3 setting.

Signed-off-by: John Ferlan <jferlan at redhat.com>
---
 src/storage/storage_backend_fs.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/src/storage/storage_backend_fs.c b/src/storage/storage_backend_fs.c
index b8f907a..0f8ceee 100644
--- a/src/storage/storage_backend_fs.c
+++ b/src/storage/storage_backend_fs.c
@@ -128,7 +128,6 @@ virStorageBackendProbeTarget(virStorageSourcePtr target,
                 virReportError(VIR_ERR_INTERNAL_ERROR,
                                _("cannot probe backing volume format: %s"),
                                target->backingStore->path);
-                ret = -3;
             } else {
                 target->backingStore->format = rc;
             }
-- 
1.9.3




More information about the libvir-list mailing list