[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 04/26] vbox: Resolve Coverity UNUSED_VALUE



Handle a few places where Coverity complains about the value being
unused. For two of them (Close cases) - the comments above the close
indicate there is no harm to ignore the error - so added an ignore_value.
For the other condition, added an rc check like other callers.

Signed-off-by: John Ferlan <jferlan redhat com>
---
 src/vbox/vbox_common.c | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)

diff --git a/src/vbox/vbox_common.c b/src/vbox/vbox_common.c
index b9858ee..10a3205 100644
--- a/src/vbox/vbox_common.c
+++ b/src/vbox/vbox_common.c
@@ -4340,6 +4340,11 @@ static int vboxCloseDisksRecursively(virDomainPtr dom, char *location)
             PRUnichar *childLocationUtf = NULL;
             char *childLocation = NULL;
             rc = gVBoxAPI.UIMedium.GetLocation(childMedium, &childLocationUtf);
+            if (NS_FAILED(rc)) {
+                virReportError(VIR_ERR_INTERNAL_ERROR, "%s",
+                               _("Unable to get childMedium location"));
+                goto cleanup;
+            }
             VBOX_UTF16_TO_UTF8(childLocationUtf, &childLocation);
             VBOX_UTF16_FREE(childLocationUtf);
             if (vboxCloseDisksRecursively(dom, childLocation) < 0) {
@@ -4762,7 +4767,7 @@ vboxSnapshotRedefine(virDomainPtr dom,
                  * succeed, unless there is still another machine which uses the
                  * medium. No harm done if we ignore the error.
                  */
-                rc = gVBoxAPI.UIMedium.Close(medium);
+                ignore_value(gVBoxAPI.UIMedium.Close(medium));
             }
             VBOX_UTF8_FREE(locationUtf8);
         }
@@ -6982,7 +6987,7 @@ vboxDomainSnapshotDeleteMetadataOnly(virDomainSnapshotPtr snapshot)
              * reference in a sane order, which means that closing will normally
              * succeed, unless there is still another machine which uses the
              * medium. No harm done if we ignore the error. */
-            rc = gVBoxAPI.UIMedium.Close(medium);
+            ignore_value(gVBoxAPI.UIMedium.Close(medium));
         }
         VBOX_UTF16_FREE(locationUtf16);
         VBOX_UTF8_FREE(locationUtf8);
-- 
1.9.3


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]