[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 02/18] blockjob: shuffle block rebase code



On 09/04/2014 09:53 AM, Peter Krempa wrote:
> On 09/04/14 16:40, Peter Krempa wrote:
>> On 08/31/14 06:02, Eric Blake wrote:
>>> The existing virDomainBlockRebase code rejected the combination of
>>> _RELATIVE and _COPY flags, but only by accident.  It makes sense,
>>> at least for the case of _SHALLOW and not _REUSE_EXT, but to
>>> implement it, libvirt would have to pre-create the file with a
>>> relative backing name.
>>>
>>> Meanwhile, the code to forward on to the block copy code is getting
>>> longer, and reorganising the function to have the block pull done
>>> early makes it easier to add even more block copy prep code.
>>>
>>> This patch should have no semantic difference other than the quality
>>> of the error message on the unsupported flag combination.

I improved the commit message to show the actual before-and-after errors,


> 
> This is then okay as-is without any change.

and pushed.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]