[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/2] conf: Disallow nonexistent NUMA nodes for hugepages



On Tue, Sep 02, 2014 at 05:12:01PM +0200, Michal Privoznik wrote:
As of 136ad4974 it is possible to specify different huge pages per
guest NUMA node. However, there's no check if nodeset specified in
./hugepages/page contains only those guest NUMA nodes that exist.
In other words with current code it is possible to define meaningless
combination:

 <memoryBacking>
   <hugepages>
     <page size='1048576' unit='KiB' nodeset='0,2-3'/>
     <page size='2048' unit='KiB' nodeset='1,4'/>
   </hugepages>
 </memoryBacking>
 <vcpu placement='static'>4</vcpu>
 <cpu>
   <numa>
     <cell id='0' cpus='0' memory='1048576'/>
     <cell id='1' cpus='1' memory='1048576'/>
     <cell id='2' cpus='2' memory='1048576'/>
     <cell id='3' cpus='3' memory='1048576'/>
   </numa>
 </cpu>

Notice the node 4 in <hugepages/>?


And with such XML, the domain will disappear after libvirt updates to
a version with the patch below.  We need to VIR_WARN() about that and
then just delete it from the definition.  Or something similar.

So NACK to this version.

Martin

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]