[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v3 15/18] blockcopy: add a way to parse disk source



On 09/05/2014 08:14 AM, Peter Krempa wrote:
> On 08/31/14 06:02, Eric Blake wrote:
>> The new blockcopy API wants to reuse only a subset of the disk
>> hotplug parser - namely, we only care about the embedded
>> virStorageSourcePtr inside a <disk> XML.  Strange as it may
>> seem, it was easier to just parse an entire disk definition,
>> then throw away everything but the embedded source, than it
>> was to disentangle the source parsing code from the rest of
>> the overall disk parsing function.  All that I needed was a
>> couple of tweaks and a new internal flag that determines
>> whether the normally-mandatory target element can be
>> gracefully skipped, since everything else was already optional.
>>

> 
> ACK, thanks for dropping the refactor part.

I've pushed this one.  I've got enough other tweaks in the remaining
patches in v3 that I'll post a v4 for them.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]