[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemu: remove leftover virResetLastError



On 09/10/2014 06:37 AM, Ján Tomko wrote:
> As of commit 5d29ca0:
> qemu: switch PCI address set from hash table to an array
> 
> There is no error to be reset.
> ---
>  src/qemu/qemu_command.c | 1 -
>  1 file changed, 1 deletion(-)

ACK

> 
> diff --git a/src/qemu/qemu_command.c b/src/qemu/qemu_command.c
> index 5856fe7..665a590 100644
> --- a/src/qemu/qemu_command.c
> +++ b/src/qemu/qemu_command.c
> @@ -1770,7 +1770,6 @@ qemuValidateDevicePCISlotsPIIX3(virDomainDefPtr def,
>              VIR_DEBUG("PCI address 0:0:2.0 in use, future addition of a video"
>                        " device will not be possible without manual"
>                        " intervention");
> -            virResetLastError();
>          } else if (virDomainPCIAddressReserveSlot(addrs, &tmp_addr, flags) < 0) {
>              goto cleanup;
>          }
> 

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]