[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] storage: zfs: implement pool build and delete



  Ján Tomko wrote:

> On 09/07/2014 04:15 PM, Roman Bogorodskiy wrote:
> > Provide an implementation for buildPool and deletePool operations for
> > the ZFS storage backend.
> > ---
> >  docs/schemas/storagepool.rng      |  1 +
> >  src/storage/storage_backend_zfs.c | 57 +++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 58 insertions(+)
> > 
> 
> ACK.

Thanks; will push closer to the weekend.

> > diff --git a/docs/schemas/storagepool.rng b/docs/schemas/storagepool.rng
> > index 908cc11..da8e1f3 100644
> > --- a/docs/schemas/storagepool.rng
> > +++ b/docs/schemas/storagepool.rng
> > @@ -386,6 +386,7 @@
> >      <element name='source'>
> >        <interleave>
> >          <ref name='sourceinfoname'/>
> > +        <ref name='sourceinfodev'/>
> >        </interleave>
> >      </element>
> >    </define>
> 
> It would be nice to add an example to docs/formatstorage.html or storage.html.
> Also an XML to the test suite to check its validity against the RNG schema.

Yes, that's true; added to my todo list.

Also, I think it'd be good to add a domain xml example to the bhyve
driver page and ideally create some unit tests for the ZFS backend code.

Roman Bogorodskiy

Attachment: pgpbJ6AZUnJym.pgp
Description: PGP signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]