[libvirt] [PATCH 05/26] qemu: Resolve Coverity REVERSE_INULL

[Peter Krempa]

On 09/05/14 00:26, John Ferlan wrote:
> Coverity complains that checking for !domlist after setting doms = domlist
> and making a deref of doms just above
> 
> It seems the call in question was intended to me made in the case that
> 'doms' was passed in and not when the virDomainObjListExport() call
> allocated domlist and already called virConnectGetAllDomainStatsCheckACL().
> 
> Thus rather than check for !domlist - check that "doms != domlist" in
> order to avoid the Coverity message.
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/qemu/qemu_driver.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

False positive, but fair enough.

ACK.

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140911/7e6788e4/attachment-0001.sig>