[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 22/26] virsh: Resolve Coverity NEGATIVE_RETURNS



On 09/05/14 00:26, John Ferlan wrote:
> Coverity notes that if virDomainGetCPUStats returns a negative value
> into 'nparams' then when we end up at cleanup, the call to virTypedParams
> will have issues
> 
> Signed-off-by: John Ferlan <jferlan redhat com>
> ---
>  tools/virsh-domain.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tools/virsh-domain.c b/tools/virsh-domain.c
> index f732a6e..6fe637b 100644
> --- a/tools/virsh-domain.c
> +++ b/tools/virsh-domain.c
> @@ -6650,6 +6650,7 @@ cmdCPUStats(vshControl *ctl, const vshCmd *cmd)
>      return ret;
>  
>   failed_stats:
> +    nparams = 0;
>      vshError(ctl, _("Failed to retrieve CPU statistics for domain '%s'"),
>               virDomainGetName(dom));
>      goto cleanup;
> 

This would cause a memleak if the second call to virDomainGetCPUStats
fails as it will jump to the same label, while "params" was already
allocated. You need to clear nparams explicitly on the first call that
determines the count of the returned stats field.

Peter

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]