[libvirt] [PATCH 0/9] More Coverity fixes
Eric Blake
eblake at redhat.com
Fri Sep 12 04:07:18 UTC 2014
On 09/11/2014 06:05 PM, John Ferlan wrote:
> There are two repeats from the last series (1 & 2).
>
> For patch 1, I went with my suggestion - I'm open to others
> For patch 2, Coverity was complaining more about the way nparams
> would be overwritten - fix that by adding a new variable
>
> New patches
> 3 & 4 -> eblake helped out with these - especially the mgetgroups oddity
> 5 -> Fallout from fixing 4
> 6 -> virTimeFieldsThen() and the "offset = 0". I'd be OK with deleting the
> code, but it just feels like someone had it on a todo list to come
> back to some day
> 7 & 8 -> Fairly straightforward
> 9 -> This was an interesting case - it seems from what was being done
> that I have the right "answer". I did go all the way back to the
> initial submission of the code and it did the same thing, except it
> was using an unsigned long instead of int and well thus wouldn't
> ever hit the condition since we're grabbing the big endian int value
Too late for me to give a competent review on 1 or 6, I may try again in
the morning when I'm not as tired. 3 and 4 are indeed tricky, but I
already helped you on it earlier in the day. I've got a question on 9,
but again, sleep may help me reason about it better.
And with that, I'm off to some much-needed sleep :)
--
Eric Blake eblake redhat com +1-919-301-3266
Libvirt virtualization library http://libvirt.org
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140911/b9f07192/attachment-0001.sig>
More information about the libvir-list
mailing list