[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 1/7] blockcopy: tweak how rebase calls into copy



On 09/12/14 05:55, Eric Blake wrote:
> In order to implement the new virDomainBlockCopy, the existing
> block copy internal implementation needs to be adjusted.  The
> new function will parse XML into a storage source, and parse
> typed parameters into integers, then call into the same common
> backend.  For now, it's easier to keep the same implementation
> limits that only local file destinations are suported, but now
> the check needs to be explicit.  Similar to qemuDomainBlockJobImpl
> consuming 'vm', this code also consumes the caller's 'mirror'
> description of the destination.
> 
> * src/qemu/qemu_driver.c (qemuDomainBlockCopy): Rename...
> (qemuDomainBlockCopyCommon): ...and adjust parameters.
> (qemuDomainBlockRebase): Adjust caller.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---
>  src/qemu/qemu_driver.c | 118 ++++++++++++++++++++++++++-----------------------
>  1 file changed, 63 insertions(+), 55 deletions(-)
> 
> diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
> index 917b286..75c529b 100644
> --- a/src/qemu/qemu_driver.c
> +++ b/src/qemu/qemu_driver.c

ACK,

Peter


Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]