[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2 2/2] formatdomain: Update <loader/> example to match the rest



On 09/12/14 13:33, Michal Privoznik wrote:
> At the beginning when I was inventing <loader/> attributes and
> <nvram/> I've introduced this @readonly attribute to the loader
> element. It accepted values 'on' and 'off'. However, later, during the
> review process, that has changed to 'yes' and 'no', but the example
> XML snippet wasn't updated, so while the description is correct, the
> example isn't.
> 
> Reported-by: Laszlo Ersek <lersek redhat com>
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  docs/formatdomain.html.in | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> index a2ea758..5081be3 100644
> --- a/docs/formatdomain.html.in
> +++ b/docs/formatdomain.html.in
> @@ -102,7 +102,7 @@
>    ...
>    &lt;os&gt;
>      &lt;type&gt;hvm&lt;/type&gt;
> -    &lt;loader readonly='on' type='rom'&gt;/usr/lib/xen/boot/hvmloader&lt;/loader&gt;
> +    &lt;loader readonly='yes' type='rom'&gt;/usr/lib/xen/boot/hvmloader&lt;/loader&gt;
>      &lt;nvram template='/usr/share/OVMF/OVMF_VARS.fd'&gt;/var/lib/libvirt/nvram/guest_VARS.fd&lt;/nvram&gt;
>      &lt;boot dev='hd'/&gt;
>      &lt;boot dev='cdrom'/&gt;
> 

Acked-by: Laszlo Ersek <lersek redhat com>


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]