[libvirt] [PATCH v4 6/7] blockjob: automatically use bytes for bandwidth in virsh

Peter Krempa pkrempa at redhat.com
Fri Sep 12 12:26:52 UTC 2014


On 09/12/14 05:55, Eric Blake wrote:
> Trickier than I had hoped; but now that we can parse numbers with
> arbitrary scale, it's time to use those numbers to call into the
> new API if the old API would have rounded the input, while still
> gracefully falling back to the old API if the new one fails.
> 
> * tools/virsh-domain.c (blockJobBandwidth): Add parameter, adjust
> return value.
> (blockJobImpl, cmdBlockCopy): Adjust callers.
> 
> Signed-off-by: Eric Blake <eblake at redhat.com>
> ---
>  tools/virsh-domain.c | 154 +++++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 113 insertions(+), 41 deletions(-)
> 

Uff this logic is fairly complex, but looks functional to me.

ACK,

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140912/41919912/attachment-0001.sig>


More information about the libvir-list mailing list