[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v4 6/7] blockjob: automatically use bytes for bandwidth in virsh



On 09/12/14 05:55, Eric Blake wrote:
> Trickier than I had hoped; but now that we can parse numbers with
> arbitrary scale, it's time to use those numbers to call into the
> new API if the old API would have rounded the input, while still
> gracefully falling back to the old API if the new one fails.
> 
> * tools/virsh-domain.c (blockJobBandwidth): Add parameter, adjust
> return value.
> (blockJobImpl, cmdBlockCopy): Adjust callers.
> 
> Signed-off-by: Eric Blake <eblake redhat com>
> ---
>  tools/virsh-domain.c | 154 +++++++++++++++++++++++++++++++++++++--------------
>  1 file changed, 113 insertions(+), 41 deletions(-)
> 

Uff this logic is fairly complex, but looks functional to me.

ACK,

Peter


Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]