[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 6/8] Resolve Coverity CHECKED_RETURN



Coverity complained that checking the return of virDomainCreate()
was not consistent amongst the callers - so added the return check
to the objecteventtest.c and adjust the virt-login-shell to compare
< 0 rather than just non zero for the failure condition.

Signed-off-by: John Ferlan <jferlan redhat com>
---
 tests/objecteventtest.c  | 3 ++-
 tools/virt-login-shell.c | 2 +-
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/tests/objecteventtest.c b/tests/objecteventtest.c
index 919f559..052dbe5 100644
--- a/tests/objecteventtest.c
+++ b/tests/objecteventtest.c
@@ -359,7 +359,8 @@ testDomainStartStopEvent(const void *data)
 
     /* Test domain is started */
     virDomainDestroy(dom);
-    virDomainCreate(dom);
+    if (virDomainCreate(dom) < 0)
+        goto cleanup;
 
     if (virEventRunDefaultImpl() < 0)
         goto cleanup;
diff --git a/tools/virt-login-shell.c b/tools/virt-login-shell.c
index be15a32..ceb271d 100644
--- a/tools/virt-login-shell.c
+++ b/tools/virt-login-shell.c
@@ -275,7 +275,7 @@ main(int argc, char **argv)
     if (!dom)
         goto cleanup;
 
-    if (!virDomainIsActive(dom) && virDomainCreate(dom)) {
+    if (!virDomainIsActive(dom) && virDomainCreate(dom) < 0) {
         virErrorPtr last_error;
         last_error = virGetLastError();
         if (last_error->code != VIR_ERR_OPERATION_INVALID) {
-- 
1.9.3


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]