[libvirt] [PATCH 2/8] virtime: Resolve Coverity DEADCODE

Peter Krempa pkrempa at redhat.com
Mon Sep 15 07:43:12 UTC 2014


On 09/13/14 15:27, John Ferlan wrote:
> Coverity complains that because of how 'offset' is initialized to
> 0 (zero), the resulting math and comparison on rem is pointless.
> 
> According to the origin commit id '3ec128989', the code is a
> replacement for gmtime(), but without the localtime() or GMT
> calculations - so just remove this code and add a comment
> indicating the removal
> 
> Signed-off-by: John Ferlan <jferlan at redhat.com>
> ---
>  src/util/virtime.c | 14 ++++----------
>  1 file changed, 4 insertions(+), 10 deletions(-)
> 

ACK

Peter


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140915/02b5e87f/attachment-0001.sig>


More information about the libvir-list mailing list