[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/5] Fix problems caused by FD passing to session daemon



On Wed, Sep 10, 2014 at 06:48:48PM -0400, John Ferlan wrote:


On 09/08/2014 01:46 AM, Martin Kletzander wrote:
There were various problems introduced by the series on FD passing.
The path for the socket was not created, the socket was not removed
before binding it, etc.  Let's see if it's any better this time.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=927369
Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1138604

Martin Kletzander (5):
  rpc: reformat the flow to make a bit more sense
  remove redundant pidfile path constructions
  util: fix potential leak in error codepath
  util: get rid of unnecessary umask() call
  rpc: make daemon spawning a bit more intelligent

 daemon/libvirtd.c         |  41 ++------------
 src/libvirt_private.syms  |   1 +
 src/locking/lock_daemon.c |  42 ++-------------
 src/rpc/virnetsocket.c    | 133 +++++++++++++++++++++++++++++++---------------
 src/util/virpidfile.c     |  48 ++++++++++++++++-
 src/util/virpidfile.h     |   7 ++-
 6 files changed, 151 insertions(+), 121 deletions(-)

--
2.1.0

--
libvir-list mailing list
libvir-list redhat com
https://www.redhat.com/mailman/listinfo/libvir-list


ACK patches 1-4, although they are a little light on patch descriptions
beyond the commit message.


I thought they are pretty self-explanatory, I just wanted to split
them to ease the review and they ended up being pretty small.  I'll
try to make the commit message more explanatory next time.

Anyway, thanks for the review, 1-4 are pushed now.

Martin

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]