[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 1/5] introduce virSnprintf helper



On 09/12/2014 08:47 PM, John Ferlan wrote:


On 09/10/2014 08:08 AM, Pavel Hrdina wrote:
Signed-off-by: Pavel Hrdina <phrdina redhat com>
---
  src/libvirt_private.syms |  1 +
  src/util/virstring.c     | 25 +++++++++++++++++++++++++
  src/util/virstring.h     | 20 ++++++++++++++++++++
  3 files changed, 46 insertions(+)


Not sure why this is necessary - I do see calls to 'snprintf' from
within existing libvirt code.  The usage you have in patch 5 could
easily use snprintf. There is no need for variable argument list.

I'm not against it, but if it's created shouldn't other snprintf's use it?

Hopefully someone else has an opinion on this...

John

OK, I'll drop it for this patch series.

[..]


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]