[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 0/7] Add more options for IOThreads

On 09/03/2014 06:15 PM, John Ferlan wrote:
> The following patches will add more support for IOThreads not completed
> from the initial patches. These changes support the remaining elements of
> bz https://bugzilla.redhat.com/show_bug.cgi?id=1101574 (working through
> unsetting the private bits - as there's nothing in there that should
> necessarily be private).
> Changes:
>  1. Add "--iothread" option to virsh attach-disk to allow using a specific
>     iothread when attaching a disk
>  2. Add the ability to set CPU affinity for an IOThread.  This involves
>     multiple steps (patches 2-6) of adding the infrastructure to support
>     setting scheduler affinity for the IOThread including cgroup setup.
>     For the most part it's a "copy" of the vCPU pinning code, but without
>     the external interfaces - those will come at a later time after RHEL7.1.
>  3. Add to <cpuset/> a new element <iothreadpin iothread='#" cpuset="string"/>
>   NOTE: I can combine any/all of patches 2-6 - I just kept them separate
>         so it wasn't a larger single patch.

IMO the split is fine as-is (maybe with the exception of the little cleanup in

> John Ferlan (7):
>   virsh: Add iothread to 'attach-disk'
>   qemu: Issue query-iothreads and to get list of active IOThreads
>   vircgroup: Introduce virCgroupNewIOThread
>   qemu_domain: Add niothreadpids and iothreadpids
>   qemu_cgroup: Introduce cgroup functions for IOThreads
>   qemu: Allow pinning specific IOThreads to a CPU
>   domain_conf: Add iothreadpin to cputune
>  22 files changed, 717 insertions(+), 15 deletions(-)
>  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-cputune-iothreads.xml

Looks good to me as well.

ACK series.


Attachment: signature.asc
Description: OpenPGP digital signature

[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]