[libvirt] [PATCHv2] network: check for invalid forward delay time

[Martin Kletzander]

On Mon, Sep 15, 2014 at 10:42:15AM +0200, Erik Skultety wrote:
>When spanning tree protocol is allowed in bridge settings, forward delay
>value is set as well (default is 0 if omitted). Until now, there was no
>check for delay value validity. Delay makes sense only as a positive
>numerical value.
>
>Note: However, even if you provide positive  numerical value, brctl
>utility only uses values from range <2,30>, so the number provided can
>be modified (kernel most likely) to fall within this range.
>
>Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1125764
>---
> docs/schemas/network.rng |  2 +-
> src/conf/network_conf.c  | 38 +++++++++++++++++++++++---------------
> src/util/virxml.c        |  2 +-
> 3 files changed, 25 insertions(+), 17 deletions(-)
>
[...]
>diff --git a/src/util/virxml.c b/src/util/virxml.c
>index cc4a85c..a91da05 100644
>--- a/src/util/virxml.c
>+++ b/src/util/virxml.c
>@@ -420,7 +420,7 @@ virXPathULongLong(const char *xpath,
> }
>
> /**
>- * virXPathULongLong:
>+ * virXPathLongLong:
>  * @xpath: the XPath string to evaluate
>  * @ctxt: an XPath context
>  * @value: the returned long long value
>--
>1.9.3
>

This hunk should be in separate patch (and the VIR_FREE(tmp) cleanups
could be too), so I pushed this one separately as a trivial (and kept
those VIR_FREE(tmp) cleanups).

ACK to the rest, pushed too.

Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140915/a09c4c72/attachment-0001.sig>