[libvirt] [PATCH] configure: Require setns in glibc
Daniel P. Berrange
berrange at redhat.com
Mon Sep 15 15:52:17 UTC 2014
On Mon, Sep 15, 2014 at 05:41:38PM +0200, Michal Privoznik wrote:
> Instead of writing our own wrapper over setns function, require
> it in glibc (when compiling with LXC). Our implementation uses
> private macros from kernel header files which should not be done.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
>
> This is an alternative approach as requested by Martin.
>
> configure.ac | 11 ++++++++++-
> src/util/virprocess.c | 33 ---------------------------------
> 2 files changed, 10 insertions(+), 34 deletions(-)
>
> diff --git a/configure.ac b/configure.ac
> index b4fb99a..0366b78 100644
> --- a/configure.ac
> +++ b/configure.ac
> @@ -274,9 +274,18 @@ dnl Availability of various common functions (non-fatal if missing),
> dnl and various less common threadsafe functions
> AC_CHECK_FUNCS_ONCE([cfmakeraw fallocate geteuid getgid getgrnam_r \
> getmntent_r getpwuid_r getuid kill mmap newlocale posix_fallocate \
> - posix_memalign prlimit regexec sched_getaffinity setgroups setns \
> + posix_memalign prlimit regexec sched_getaffinity setgroups \
> setrlimit symlink sysctlbyname getifaddrs])
>
> +AC_CHECK_FUNC([setns])
> +if test "$ac_cv_func_setns" = "no" ; then
> + if "$with_lxc" = "check" ; then
> + with_lxc=no
> + elif "$with_lxc" = "yes" ; then
> + AC_MSG_ERROR([setns function is required for LXC])
> + fi
> +fi
NACK, this effectively drops the LXC driver for many distros.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list