[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCHv2] network: check negative values in bridge queues



On Tue, Sep 16, 2014 at 10:06:50AM +0200, Erik Skultety wrote:
We already are checking for negative value, reporting an error, but
using wrong function and the check only succeeds when a value that
cannot be converted to number successfully is encountered. This patch
provides just a minor change in call of the right version
of function virStrToLong.

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1138539
---
src/conf/domain_conf.c                             |  2 +-
.../qemuxml2argv-vhost_queues-invalid.xml          | 32 ++++++++++++++++++++++
tests/qemuxml2argvtest.c                           |  1 +
3 files changed, 34 insertions(+), 1 deletion(-)
create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-vhost_queues-invalid.xml


Thanks a lot for the tests, ACK && pushed now.

Martin

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]