[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH 1/1] qemu: Add support for multiple versions of 'pseries' machine type



On 09/17/2014 11:02 AM, Pradipta Kumar Banerjee wrote:
> On 09/15/2014 07:46 PM, Ján Tomko wrote:
>> On 09/13/2014 05:28 PM, Pradipta Kr. Banerjee wrote:
>>> qemu: Add support for multiple versions of 'pseries' machine type
>>>
>>> qemu for IBM Power processor architecture is adding functionality for
>>> supporting multiple 'pseries' machine type versions, each with different
>>> capabilities. This patch is for supporting the same
>>>
>>> Signed-off-by: Pradipta Kr. Banerjee <bpradip in ibm com>
>>> ---
>>>  src/qemu/qemu_command.c | 18 +++++++++---------
>>>  1 file changed, 9 insertions(+), 9 deletions(-)
>>
>> ACK.
>>
>> Would you like to add a qemuxml2argvtest for 'pseries-2.1' machine with these
>> devices?
> As of now there are no changes to qemu command line invocation based on
> different machine type. If required for this patch I'll go ahead and add the
> test cases for pseries-2.1 and pseries-2.2.

It is not required for the patch, I just thought a test would help to make
sure that we don't break the old machine types if we ever change something in
the code.

I've pushed the patch now.

> pseries-2.2 is the latest which
> aliases to pseries. Please do let me know your thoughts.

Oh, so it's the other way than on x86_64 where 'pc' is the alias for the
latest pc-i440fx machine (pc-i440fx-2.2 as of now).

Jan

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]