[libvirt] [PATCH] Move the FIPS detection from capabilities

Eric Blake eblake at redhat.com
Thu Sep 18 16:48:41 UTC 2014


On 09/18/2014 10:44 AM, Pavel Hrdina wrote:

>> Ouch.  This will make our testsuite differ based on whether it is run on
>> Linux in FIPS mode (where FIPS might exist) or on any other setup.  I
>> think you need to hoist the check for virFileExists() to the caller, and
>> pass in the result as a new bool parameter to this function, so that the
>> testsuite has full control over the boolean without regards to the
>> current system's level of FIPS support.
>>
> 
> Sigh, that's right. I've completely forget about the tests. And that
> reminds me whether we should also revert the test for enable-fips as it
> seems to be pointless?

It's still worth testing that we can add or avoid '-enable-fips' in the
generated command line according to the boolean value we pass in.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 539 bytes
Desc: OpenPGP digital signature
URL: <http://listman.redhat.com/archives/libvir-list/attachments/20140918/bbec2705/attachment-0001.sig>


More information about the libvir-list mailing list