[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] Move the FIPS detection from capabilities



On 09/18/2014 10:55 AM, Pavel Hrdina wrote:
> On 09/18/2014 06:48 PM, Eric Blake wrote:
>> On 09/18/2014 10:44 AM, Pavel Hrdina wrote:
>>
>>>> Ouch.  This will make our testsuite differ based on whether it is
>>>> run on
>>>> Linux in FIPS mode (where FIPS might exist) or on any other setup.  I
>>>> think you need to hoist the check for virFileExists() to the caller,
>>>> and
>>>> pass in the result as a new bool parameter to this function, so that
>>>> the
>>>> testsuite has full control over the boolean without regards to the
>>>> current system's level of FIPS support.
>>>>
>>>
>>> Sigh, that's right. I've completely forget about the tests. And that
>>> reminds me whether we should also revert the test for enable-fips as it
>>> seems to be pointless?
>>
>> It's still worth testing that we can add or avoid '-enable-fips' in the
>> generated command line according to the boolean value we pass in.
>>
> 
> Yes I agree and that's why I would like to remove the test from
> qemucapabilitiestest and create a new one in qemuxml2argvtest.

Yes, that makes sense.

-- 
Eric Blake   eblake redhat com    +1-919-301-3266
Libvirt virtualization library http://libvirt.org

Attachment: signature.asc
Description: OpenPGP digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]