[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

[libvirt] [PATCH 0/4] bulk stats: QEMU implementation polishing



This patchset does polishing on the QEMU bulk stats implementation.
The main issue this patchset addresses is that, unless a critical
error is found, bulk stats should be silent and ignore errors.

To do so, virResetLastError() is used in a few places, but this
is not enough since errors are logged anyway.
A better approach is to avoid to report error entirely.

The patchset is organized as follows:
- patches 1 to 3 enhances the functions used in the bulk stats
  path(s) adding a 'bool report' flag, to let the caller optionally
  suppress error reporting.
- patch 4 is a general polishing patch which reduces repetition
  of the code in the block stats collection.

Francesco Romani (4):
  qemu: make qemuDomainHelperGetVcpus silent
  make virNetInterfaceStats silent
  qemu: make qemuMonitorGetAllBlockStatsInfo silent
  qemu: json monitor: reduce duplicated code

 src/lxc/lxc_driver.c         |   2 +-
 src/openvz/openvz_driver.c   |   2 +-
 src/qemu/qemu_driver.c       |  32 +++++-----
 src/qemu/qemu_monitor.c      |  12 ++--
 src/qemu/qemu_monitor.h      |   3 +-
 src/qemu/qemu_monitor_json.c | 136 ++++++++++++++++++++-----------------------
 src/qemu/qemu_monitor_json.h |   3 +-
 src/util/virstats.c          |  21 ++++---
 src/util/virstats.h          |   3 +-
 src/xen/xen_hypervisor.c     |   2 +-
 10 files changed, 111 insertions(+), 105 deletions(-)

-- 
1.9.3


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]