[libvirt] [PATCH 1/2] qemu: Fix updating bandwidth limits in live XML

Erik Skultety eskultet at redhat.com
Mon Sep 22 10:41:30 UTC 2014


When trying to update bandwidth limits on a running domain, limits get
updated in our internal structures, however XML parser reads
bandwidth limits from network 'actual' definition. Commiting this patch
it is now available to update bandwidth 'actual' definition as well,
thus updating domain runtime XML
---
 src/qemu/qemu_driver.c | 12 ++++++++++++
 1 file changed, 12 insertions(+)

diff --git a/src/qemu/qemu_driver.c b/src/qemu/qemu_driver.c
index 702d3cc..ede8880 100644
--- a/src/qemu/qemu_driver.c
+++ b/src/qemu/qemu_driver.c
@@ -10028,7 +10028,19 @@ qemuDomainSetInterfaceParameters(virDomainPtr dom,
         } else {
             net->bandwidth = NULL;
         }
+
+        if (net->type == VIR_DOMAIN_NET_TYPE_NETWORK) {
+                virNetDevBandwidthFree(net->data.network.actual->bandwidth);
+                if (!net->bandwidth ||
+                    virNetDevBandwidthCopy(&net->data.network.actual->bandwidth,
+                                           net->bandwidth) < 0)
+                    net->data.network.actual->bandwidth = NULL;
+        }
+
+        if (virDomainSaveStatus(driver->xmlopt, cfg->stateDir, vm) < 0)
+            goto cleanup;
     }
+
     if (flags & VIR_DOMAIN_AFFECT_CONFIG) {
         if (!persistentNet->bandwidth) {
             persistentNet->bandwidth = bandwidth;
-- 
1.9.3




More information about the libvir-list mailing list