[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [Qemu-devel] [PATCH v3 1/2] Add machine type pc-1.0-qemu-kvm for live migrate compatibility with qemu-kvm



Michael,

(Reordering)

On 22 Sep 2014, at 12:50, Michael S. Tsirkin <mst redhat com> wrote:

> 
>> @@ -257,6 +259,11 @@ static int pit_dispatch_post_load(void *opaque, int version_id)
>>     return 0;
>> }
>> 
>> +static bool has_irq_disabled(void *opaque, int version_id)
>> +{
>> +    return (version_id >= 3) || ((version_id == 2) && qemu_kvm_1_0_compat);
>> +}
>> +
> Can you add a device property like we do for
> other compat behaviours?
> That's better than a global variable.
> Same for other devices.

I can see 'opaque' points to PIIX4PMState or PITCommonState. Do you mean
to put them in there? Could you point to an example to copy.

-- 
Alex Bligh






[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]