[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] qemuBuildNumaArgStr: Discard def->cpu check




On 09/23/2014 07:12 AM, Michal Privoznik wrote:
> In the function at one place we check if def->cpu is NULL prior
> to accessing def->cpu->ncells. Then, later in the code,
> def->cpu->ncells is accessed directly, without the check. This
> makes coverity unhappy, because the first check makes it think
> def->cpu can be NULL. However, the function is not called if
> def->cpu is NULL. Therefore, remove the first check and hopefully
> make coverity cheer again.
> 
> Signed-off-by: Michal Privoznik <mprivozn redhat com>
> ---
>  src/qemu/qemu_command.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 

It did... ACK

Tks -

John


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]