[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] LXC: emphasis uid start of idmap only accept '0' in docs




> -----Original Message-----
> From: Michal Privoznik [mailto:mprivozn redhat com]
> 
> On 23.09.2014 05:40, Chen Hanxiao wrote:
> > We don't accept any other values except '0'.
> >
> > Signed-off-by: Chen Hanxiao <chenhanxiao cn fujitsu com>
> > ---
> >   docs/formatdomain.html.in | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/docs/formatdomain.html.in b/docs/formatdomain.html.in
> > index eefdd5e..bb72452 100644
> > --- a/docs/formatdomain.html.in
> > +++ b/docs/formatdomain.html.in
> > @@ -315,7 +315,7 @@
> >
> >       <dl>
> >         <dt><code>start</code></dt>
> > -      <dd>First user ID in container.</dd>
> > +      <dd>First user ID in container. It must be '0'.</dd>
> >         <dt><code>target</code></dt>
> >         <dd>The first user ID in container will be mapped to this target user
> >             ID in host.</dd>
> >
> 
> This is not entirely true. Only the first id mapping must refer to root.
> And by first I mean in a sorted array of mappings. For instance:
> 
> <idmap>
>    <uid start='1' target='1001' count='1'/>
>    <gid start='1' target='1001' count='1'/>
>    <uid start='0' target='1000' count='1'/>
>    <gid start='0' target='1000' count='1'/>
> </idmap>
> 
> is okay.

I missed that part.
Thanks for clarification.

- Chen


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]