[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] conf: report error in virCPUDefParseXML



On Thu, Sep 25, 2014 at 12:23:31PM +0800, Jincheng Miao wrote:
When detected invalid 'memAccess', virCPUDefParseXML should report error.

Resolves https://bugzilla.redhat.com/show_bug.cgi?id=1146334

Signed-off-by: Jincheng Miao <jmiao redhat com>
---
src/conf/cpu_conf.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/src/conf/cpu_conf.c b/src/conf/cpu_conf.c
index 116aa58..a1081b9 100644
--- a/src/conf/cpu_conf.c
+++ b/src/conf/cpu_conf.c
@@ -510,13 +510,13 @@ virCPUDefParseXML(xmlNodePtr node,
                def->cells[cur_cell].memAccess =
                    virMemAccessTypeFromString(memAccessStr);

-                if (def->cells[cur_cell].memAccess <= 0) {
+                if ((int)def->cells[cur_cell].memAccess <= 0) {

Any reason for the explicit cast in here?

                    virReportError(VIR_ERR_CONFIG_UNSUPPORTED,
                                   _("Invalid 'memAccess' attribute "
                                     "value '%s'"),
                                   memAccessStr);
                    VIR_FREE(memAccessStr);
-                    goto cleanup;
+                    goto error;

ACK to this line.

Martin

Attachment: signature.asc
Description: Digital signature


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]