[libvirt] [PATCH] virnetserver: Raise log level of max_clients related messages
Daniel P. Berrange
berrange at redhat.com
Thu Sep 25 11:45:17 UTC 2014
On Thu, Sep 25, 2014 at 01:39:13PM +0200, Michal Privoznik wrote:
> We have these configuration knobs, like max_clients and
> max_anonymous_clients. They limit the number of clients
> connected. Whenever the limit is reached, the daemon stops
> accepting new ones and resumes if one of the connected clients
> disconnects. If that's the case, a debug message is printed into
> the logs. And when the daemon starts over to accept new clients
> too. However, the problem is the messages have debug priority.
> This may be unfortunate, because if the daemon stops accepting
> new clients all of a sudden, and users don't have debug logs
> enabled they have no idea what's going on. Raise the messages
> level to INFO at least.
>
> Signed-off-by: Michal Privoznik <mprivozn at redhat.com>
> ---
> src/rpc/virnetserver.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
ACK this is a good example of the kind of thing that INFO log
level is suitable for.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
More information about the libvir-list
mailing list