[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH] storage: Fix logical pool fmt type unknown->auto



There is an existing NACK patch:
https://www.redhat.com/archives/libvir-list/2014-June/msg00809.html

On 09/25/2014 08:13 PM, Erik Skultety wrote:
According to our documentation logical pool supports formats 'auto' and
'lvm2'. However, in storage_conf.c we prevously defined storage pool
formats: unknown, lvm2. Format 'auto' does make more sense than
format 'unknown', so we should probably stay consistent with the
documentation

Resolves: https://bugzilla.redhat.com/show_bug.cgi?id=1123767
---
  src/conf/storage_conf.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/conf/storage_conf.c b/src/conf/storage_conf.c
index 36696a4..75004fe 100644
--- a/src/conf/storage_conf.c
+++ b/src/conf/storage_conf.c
@@ -81,7 +81,7 @@ VIR_ENUM_IMPL(virStoragePoolFormatDisk,
VIR_ENUM_IMPL(virStoragePoolFormatLogical,
                VIR_STORAGE_POOL_LOGICAL_LAST,
-              "unknown", "lvm2")
+              "auto", "lvm2")
VIR_ENUM_IMPL(virStorageVolFormatDisk,


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]