[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]

Re: [libvirt] [PATCH v2 0/3] Add support for shared memory devices



On 25.09.2014 11:45, Martin Kletzander wrote:
This is based on Maxime's patches, but leaving out the last one with
server starting, the last version was here:

https://www.redhat.com/archives/libvir-list/2014-August/msg01032.html

There were some points raised, some discussion went on.  Basically
whatever we agreed is composed in, but feel free to raise questions
and further discussions.  However it would be really great if this
could get into 1.2.9 release.


Martin Kletzander (2):
   docs, conf, schema: add support for shmem device
   qemu: Build command line for ivshmem device

Maxime Leroy (1):
   qemu: add capability probing for ivshmem device

  docs/formatdomain.html.in                          |  52 +++++
  docs/schemas/domaincommon.rng                      |  39 ++++
  src/conf/domain_conf.c                             | 210 ++++++++++++++++++++-
  src/conf/domain_conf.h                             |  24 +++
  src/qemu/qemu_capabilities.c                       |   2 +
  src/qemu/qemu_capabilities.h                       |   1 +
  src/qemu/qemu_command.c                            | 118 +++++++++++-
  src/qemu/qemu_command.h                            |   1 +
  src/qemu/qemu_hotplug.c                            |   1 +
  tests/qemucapabilitiesdata/caps_1.2.2-1.caps       |   1 +
  tests/qemucapabilitiesdata/caps_1.3.1-1.caps       |   1 +
  tests/qemucapabilitiesdata/caps_1.4.2-1.caps       |   1 +
  tests/qemucapabilitiesdata/caps_1.5.3-1.caps       |   1 +
  tests/qemucapabilitiesdata/caps_1.6.0-1.caps       |   1 +
  tests/qemucapabilitiesdata/caps_1.6.50-1.caps      |   1 +
  tests/qemucapabilitiesdata/caps_2.1.1-1.caps       |   1 +
  tests/qemuhelptest.c                               |  15 +-
  .../qemuxml2argv-shmem-invalid-size.xml            |  24 +++
  .../qemuxml2argv-shmem-invalid.xml                 |  24 +++
  .../qemuxml2argv-shmem-msi-only.xml                |  24 +++
  .../qemuxml2argv-shmem-small-size.xml              |  24 +++
  tests/qemuxml2argvdata/qemuxml2argv-shmem.args     |  16 ++
  tests/qemuxml2argvdata/qemuxml2argv-shmem.xml      |  51 +++++
  tests/qemuxml2argvtest.c                           |   8 +
  tests/qemuxml2xmltest.c                            |   1 +
  25 files changed, 635 insertions(+), 7 deletions(-)
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-shmem-invalid-size.xml
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-shmem-invalid.xml
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-shmem-msi-only.xml
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-shmem-small-size.xml
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-shmem.args
  create mode 100644 tests/qemuxml2argvdata/qemuxml2argv-shmem.xml

ACK series, but see my inline comments.

Michal


[Date Prev][Date Next]   [Thread Prev][Thread Next]   [Thread Index] [Date Index] [Author Index]